chore(lint): use eslint v9 (#197)

* chore(lint): use eslint v9 * chore(ci): remove node 19 tests
honojs · Sep 12, 2024 · d560932 · d560932
1 parent fc74926
commit d560932
Show file tree

Hide file tree

Showing 12 changed files with 311 additions and 865 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 19.x, 20.x, 22.x]
+        node-version: [18.x, 20.x, 22.x]
 
     steps:
       - uses: actions/checkout@v4

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,3 @@
+import baseConfig from '@hono/eslint-config'
+
+export default [...baseConfig]
diff --git a/package.json b/package.json
@@ -60,8 +60,8 @@
     "postbuild": "publint",
     "prerelease": "yarn build && yarn test",
     "release": "np",
-    "lint": "eslint --ext js,ts src test",
-    "lint:fix": "eslint --ext js,ts src test --fix",
+    "lint": "eslint src test",
+    "lint:fix": "eslint src test --fix",
     "format": "prettier --check \"src/**/*.{js,ts}\" \"test/**/*.{js,ts}\"",
     "format:fix": "prettier --write \"src/**/*.{js,ts}\" \"test/**/*.{js,ts}\""
   },
@@ -80,12 +80,12 @@
     "node": ">=18.14.1"
   },
   "devDependencies": {
-    "@hono/eslint-config": "^0.0.4",
+    "@hono/eslint-config": "^1.0.1",
     "@types/jest": "^29.5.3",
     "@types/node": "^20.10.0",
     "@types/supertest": "^2.0.12",
     "@whatwg-node/fetch": "^0.9.14",
-    "eslint": "^8.55.0",
+    "eslint": "^9.10.0",
     "hono": "^4.4.10",
     "jest": "^29.6.1",
     "np": "^7.7.0",

diff --git a/src/conninfo.ts b/src/conninfo.ts
@@ -1,5 +1,5 @@
-import type { AddressInfo } from 'net'
 import type { GetConnInfo } from 'hono/conninfo'
+import type { AddressInfo } from 'net'
 import type { HttpBindings } from './types'
 
 /**

diff --git a/src/response.ts b/src/response.ts
@@ -99,7 +99,6 @@ export function getInternalBody(
     response = (response as any)[getResponseCache]()
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const state = (response as any)[stateKey] as { body?: InternalBody } | undefined
 
   return (state && state.body) || undefined

diff --git a/src/serve-static.ts b/src/serve-static.ts
@@ -1,8 +1,8 @@
-import type { ReadStream, Stats } from 'fs'
-import { createReadStream, lstatSync } from 'fs'
 import type { Context, MiddlewareHandler } from 'hono'
 import { getFilePath, getFilePathWithoutDefaultDocument } from 'hono/utils/filepath'
 import { getMimeType } from 'hono/utils/mime'
+import { createReadStream, lstatSync } from 'fs'
+import type { ReadStream, Stats } from 'fs'
 
 export type ServeStaticOptions = {
   /**

diff --git a/test/conninfo.test.ts b/test/conninfo.test.ts
@@ -1,6 +1,6 @@
-import type { AddressInfo } from 'net'
 import { Hono } from 'hono'
 import type { AddressType, ConnInfo } from 'hono/conninfo'
+import type { AddressInfo } from 'net'
 import { getConnInfo } from '../src/conninfo'
 
 describe('ConnInfo', () => {

diff --git a/test/listener.test.ts b/test/listener.test.ts
@@ -1,5 +1,5 @@
-import { createServer } from 'node:http'
 import request from 'supertest'
+import { createServer } from 'node:http'
 import { getRequestListener } from '../src/listener'
 import { GlobalRequest, Request as LightweightRequest, RequestError } from '../src/request'
 import { GlobalResponse, Response as LightweightResponse } from '../src/response'

diff --git a/test/response.test.ts b/test/response.test.ts
@@ -1,4 +1,5 @@
-import { createServer, type Server } from 'node:http'
+import { createServer } from 'node:http'
+import type { Server } from 'node:http'
 import type { AddressInfo } from 'node:net'
 import { GlobalResponse, Response as LightweightResponse } from '../src/response'
 

diff --git a/test/server.test.ts b/test/server.test.ts
@@ -1,6 +1,3 @@
-import fs from 'node:fs'
-import { createServer as createHttp2Server } from 'node:http2'
-import { createServer as createHTTPSServer } from 'node:https'
 import { Response as PonyfillResponse } from '@whatwg-node/fetch'
 import { Hono } from 'hono'
 import { basicAuth } from 'hono/basic-auth'
@@ -9,6 +6,9 @@ import { etag } from 'hono/etag'
 import { poweredBy } from 'hono/powered-by'
 import { stream } from 'hono/streaming'
 import request from 'supertest'
+import fs from 'node:fs'
+import { createServer as createHttp2Server } from 'node:http2'
+import { createServer as createHTTPSServer } from 'node:https'
 import { GlobalRequest, Request as LightweightRequest, getAbortController } from '../src/request'
 import { GlobalResponse, Response as LightweightResponse } from '../src/response'
 import { createAdaptorServer } from '../src/server'