-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ConnInfo helper #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @nakasyou I'll review it but, should we upgrade |
@yusukebe probably yes. |
4 tasks
Good 👍 |
yusukebe
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @nakasyou I've updated the branch to pass the CI. Looks good. Merging now. Thanks! |
adamnolte
referenced
this pull request
in autoblocksai/cli
Jul 24, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@hono/node-server](https://togithub.com/honojs/node-server) | [`1.11.4` -> `1.12.0`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/1.11.4/1.12.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@hono%2fnode-server/1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@hono%2fnode-server/1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@hono%2fnode-server/1.11.4/1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@hono%2fnode-server/1.11.4/1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/node-server (@​hono/node-server)</summary> ### [`v1.12.0`](https://togithub.com/honojs/node-server/releases/tag/v1.12.0) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.11.5...v1.12.0) #### What's Changed - fix(serve-static): supports extension less files by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/node-server/pull/183](https://togithub.com/honojs/node-server/pull/183) - feat: implement ConnInfo helper by [@​nakasyou](https://togithub.com/nakasyou) in [https://github.com/honojs/node-server/pull/180](https://togithub.com/honojs/node-server/pull/180) #### New Contributors - [@​nakasyou](https://togithub.com/nakasyou) made their first contribution in [https://github.com/honojs/node-server/pull/180](https://togithub.com/honojs/node-server/pull/180) **Full Changelog**: honojs/node-server@v1.11.5...v1.12.0 ### [`v1.11.5`](https://togithub.com/honojs/node-server/releases/tag/v1.11.5) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.11.4...v1.11.5) #### What's Changed - fix: make `hono` as external to build by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/node-server/pull/182](https://togithub.com/honojs/node-server/pull/182) **Full Changelog**: honojs/node-server@v1.11.4...v1.11.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 17, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented ConnInfo helper for Node.js.
Example:
The helper uses env to get Node.js HTTP Bindings.
If you'd like to use env, you can write code like: