Merge to master #19
Merged
Merge to master #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the CD workflow to run on pull requests and ensure the deploy job runs only on push to the master branch. * Add `pull_request` trigger to the `on` section in `.github/workflows/CD.yml` to run the CD workflow on pull requests. * Ensure the `deploy` job in `.github/workflows/CD.yml` runs only when a commit is pushed to the `master` branch.
* Change CI badge links in the Persian Date Public Version table to use `CI.yml` * Update CI pipeline description to reference `.github/workflows/CI.yml` instead of `.github/workflows/CD.yml`
Fix the CI name to CI and ensure CD runs on pull request
…irements Add setup and run instructions to `README.md`. * **Requirements**: Add a section mentioning the .NET 8.0 SDK requirement. * **Setup and Run**: Add a section with steps to install .NET 8.0 SDK, restore dependencies, build the project, and run tests.
Improve readme file and add how to setup and run project and the requirements
Add GitHub Packages registry configuration and update CD pipeline to publish package to GitHub Packages. * **PersianDate/PersianDate.csproj** - Update `<RepositoryUrl>` to `https://github.com/hootanht/PersianDate`. - Change `<PackageSource>` to `https://nuget.pkg.github.com/hootanht/index.json`. * **.github/workflows/CD.yml** - Add step to authenticate with GitHub Packages using the `GITHUB_TOKEN` secret. - Add step to publish NuGet package to GitHub Packages. - Rename existing step to publish NuGet package to NuGet.org.
Add GitHub Packages support
hootanht
added a commit
that referenced
this pull request
Sep 12, 2024
Merge pull request #19 from hootanht/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.