Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CD error #25

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix CD error #25

merged 1 commit into from
Sep 12, 2024

Conversation

hootanht
Copy link
Owner

Update the CD workflow to fix the version extraction error.

  • PersianDate/PersianDate.csproj

    • Add a new property group with VersionPrefix set to 1.0.6 and VersionSuffix set to ci.
  • .github/workflows/CD.yml

    • Update the Get version from csproj step to use dotnet msbuild to extract the version.
    • Replace the existing run command with dotnet msbuild -nologo -t:GetVersion -v:q -p:VersionPrefix=1.0.6 -p:VersionSuffix=ci.
    • Update the echo command to set the VERSION output to the extracted version.

Update the CD workflow to fix the version extraction error.

* **PersianDate/PersianDate.csproj**
  - Add a new property group with `VersionPrefix` set to `1.0.6` and `VersionSuffix` set to `ci`.

* **.github/workflows/CD.yml**
  - Update the `Get version from csproj` step to use `dotnet msbuild` to extract the version.
  - Replace the existing `run` command with `dotnet msbuild -nologo -t:GetVersion -v:q -p:VersionPrefix=1.0.6 -p:VersionSuffix=ci`.
  - Update the `echo` command to set the `VERSION` output to the extracted version.
@hootanht hootanht merged commit da6d25f into master Sep 12, 2024
3 checks passed
@hootanht hootanht deleted the fix-cd-error branch September 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant