fix(slo): Slices without any data event are considered good (elastic#…

…196942)
hop-dev · Oct 23, 2024 · 75f6db1 · 75f6db1
1 parent 96c6aa7
commit 75f6db1
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 19 deletions.
diff --git a/.../server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap b/.../server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap
diff --git a/...erver/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap b/...erver/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap
diff --git a/...ty_solution/slo/server/services/transform_generators/__snapshots__/histogram.test.ts.snap b/...ty_solution/slo/server/services/transform_generators/__snapshots__/histogram.test.ts.snap
diff --git a/...y_solution/slo/server/services/transform_generators/__snapshots__/kql_custom.test.ts.snap b/...y_solution/slo/server/services/transform_generators/__snapshots__/kql_custom.test.ts.snap
diff --git a/...olution/slo/server/services/transform_generators/__snapshots__/metric_custom.test.ts.snap b/...olution/slo/server/services/transform_generators/__snapshots__/metric_custom.test.ts.snap
diff --git a/...servability_solution/slo/server/services/transform_generators/apm_transaction_duration.ts b/...servability_solution/slo/server/services/transform_generators/apm_transaction_duration.ts
@@ -185,9 +185,9 @@ export class ApmTransactionDurationTransformGenerator extends TransformGenerator
               goodEvents: 'slo.numerator.value',
               totalEvents: 'slo.denominator.value',
             },
-            script: `params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
+            script: `if (params.totalEvents == 0) { return 1 } else { return params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
               slo.objective.timesliceTarget!
-            )} ${slo.objective.timesliceTarget} ? 1 : 0`,
+            )} ${slo.objective.timesliceTarget} ? 1 : 0 }`,
           },
         },
       }),

diff --git a/...rvability_solution/slo/server/services/transform_generators/apm_transaction_error_rate.ts b/...rvability_solution/slo/server/services/transform_generators/apm_transaction_error_rate.ts
@@ -168,9 +168,9 @@ export class ApmTransactionErrorRateTransformGenerator extends TransformGenerato
               goodEvents: 'slo.numerator>_count',
               totalEvents: 'slo.denominator>_count',
             },
-            script: `params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
+            script: `if (params.totalEvents == 0) { return 1 } else { return params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
               slo.objective.timesliceTarget!
-            )} ${slo.objective.timesliceTarget} ? 1 : 0`,
+            )} ${slo.objective.timesliceTarget} ? 1 : 0 }`,
           },
         },
       }),

diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/histogram.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/histogram.ts
@@ -101,9 +101,9 @@ export class HistogramTransformGenerator extends TransformGenerator {
               goodEvents: 'slo.numerator>value',
               totalEvents: 'slo.denominator>value',
             },
-            script: `params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
+            script: `if (params.totalEvents == 0) { return 1 } else { return params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
               slo.objective.timesliceTarget!
-            )} ${slo.objective.timesliceTarget} ? 1 : 0`,
+            )} ${slo.objective.timesliceTarget} ? 1 : 0 }`,
           },
         },
       }),

diff --git a/x-pack/plugins/observability_solution/slo/server/services/transform_generators/kql_custom.ts b/x-pack/plugins/observability_solution/slo/server/services/transform_generators/kql_custom.ts
@@ -94,9 +94,9 @@ export class KQLCustomTransformGenerator extends TransformGenerator {
               goodEvents: 'slo.numerator>_count',
               totalEvents: 'slo.denominator>_count',
             },
-            script: `params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
+            script: `if (params.totalEvents == 0) { return 1 } else { return params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
               slo.objective.timesliceTarget!
-            )} ${slo.objective.timesliceTarget} ? 1 : 0`,
+            )} ${slo.objective.timesliceTarget} ? 1 : 0 }`,
           },
         },
       }),

diff --git a/.../plugins/observability_solution/slo/server/services/transform_generators/metric_custom.ts b/.../plugins/observability_solution/slo/server/services/transform_generators/metric_custom.ts
@@ -105,9 +105,9 @@ export class MetricCustomTransformGenerator extends TransformGenerator {
               goodEvents: 'slo.numerator>value',
               totalEvents: 'slo.denominator>value',
             },
-            script: `params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
+            script: `if (params.totalEvents == 0) { return 1 } else { return params.goodEvents / params.totalEvents ${getTimesliceTargetComparator(
               slo.objective.timesliceTarget!
-            )} ${slo.objective.timesliceTarget} ? 1 : 0`,
+            )} ${slo.objective.timesliceTarget} ? 1 : 0 }`,
           },
         },
       }),