[update.pre.commit.hook] Updated pre-commit git hook #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not an issue introduced in this MR but I wonder if we should try to find the paths to the binary in case somebody has already aliased it. Something along the lines of |
kopperp
approved these changes
Aug 29, 2023
kopperp
force-pushed
the
update.pre.commit.hook
branch
from
01aceb4 to
e2ead78
Compare
|
@scopplestone Are we good to merge it with those changes? |
kopperp
force-pushed
the
update.pre.commit.hook
branch
from
e2ead78 to
e0012ab
Compare
Some commands might be already aliased to something else and not do what is expected
kopperp
force-pushed
the
update.pre.commit.hook
branch
from
e0012ab to
a41a538
Compare
scopplestone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow executables to be committed.