This repository has been archived by the owner on Dec 26, 2021. It is now read-only.
Added Full CMake support + Fixed Errors #4504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with CMake and VS |
|
the check fails though, might have to do with the submodule |
|
@richardletshacks that's because of MinHook linking, for my mashine it worked without any problems. I will try to fix it soon or later. |
|
@richardletshacks now it compiles without problems! |
|
please open separate pull requests, 163a17a shouldn't be included in this one. |
|
@richardletshacks sry didn't read, but this is a minimal addition (that I need), so it shouldn't affect anything |
richardletshacks
requested review from
GodGamer029
and removed request for
GodGamer029
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.