feat : adding channel contract and tests #120
Conversation
src/channel/channel.cairo
Outdated
| channels: Map<u256, channelParams>, | ||
| channel_counter: u256, | ||
| channel_members: Map<ContractAddress, channelMember>, | ||
| channel_moderators: Map<(u256, ContractAddress), bool>, |
There was a problem hiding this comment.
this should be a mapping of channel_id -> vec<Moderator addresses>
so it's easier to retrieve all associated moderators for a channel
src/channel/channel.cairo
Outdated
| token_id: u256, | ||
| block_timestamp: u64, | ||
| } | ||
| // this should also contain the IChannel & IChannelNFT implmentation , waht is the self what d. |
There was a problem hiding this comment.
can you throw more light on what this comment means?
src/channel/channel.cairo
Outdated
| } | ||
|
|
||
|
|
||
| // mnaking the constructor to store the onwer , who can set the moderators |
There was a problem hiding this comment.
we do not need a constructor to do this
src/channel/channel.cairo
Outdated
| // check that i prioor not baned | ||
| let channel_member: channelMember = self.channel_members.read(get_caller_address()); | ||
| assert(!channel_member.ban_status, BANNED_FROM_CHANNEL); | ||
|
|
There was a problem hiding this comment.
we also need an extra check to ensure that the user is a member of the community, the channel belongs to. You shouldn't be able to join a channel of a community you do not belong to.
To do this, you need to inherit the community component and check the user's membership
src/base/constants/types.cairo
Outdated
| // * @param channel_premium_status | ||
| // */ | ||
| #[derive(Drop, Serde, Clone, starknet::Store)] | ||
| pub struct channelParams { |
There was a problem hiding this comment.
this should also contain the community_id of the community the channel belongs to
src/channel/channel.cairo
Outdated
| self.channels.read(channel_id).channel_owner == get_caller_address(), | ||
| NOT_CHANNEL_OWNER | ||
| ); | ||
|
|
There was a problem hiding this comment.
you might also want to check that the address is an existing moderator
src/channel/channel.cairo
Outdated
| self.channels.read(channel_id).channel_owner == get_caller_address() | ||
| || self.channel_moderators.read((channel_id, get_caller_address())), | ||
| NOT_CHANNEL_MODERATOR | ||
| ); |
There was a problem hiding this comment.
check that profile being banned exists
src/interfaces/IChannel.cairo
Outdated
| fn set_ban_status( | ||
| ref self: TState, channel_id: u256, profile: ContractAddress, ban_status: bool | ||
| ); | ||
| // // ************************************************************************* |
There was a problem hiding this comment.
why does this have double starting comments?
src/channel/channel.cairo
Outdated
| channel_nft_address: channel_params.channel_nft_address, | ||
| channel_total_members: 0, | ||
| channel_censorship: channel_params.channel_censorship, | ||
| }; |
There was a problem hiding this comment.
deploy channel nft when a new channel is created. make reference to the community component implementation
src/channel/channel.cairo
Outdated
| channel_total_members: 0, | ||
| channel_censorship: channel_params.channel_censorship, | ||
| }; | ||
| // increment |
There was a problem hiding this comment.
Add channel owner as the first member of the channel
src/channel/channel.cairo
Outdated
| let channel_member: channelMember = self | ||
| .channel_members | ||
| .read((channel_id, get_caller_address())); | ||
| assert(!channel_member.ban_status, BANNED_FROM_CHANNEL); |
There was a problem hiding this comment.
also check that profile is not previously a member of the channel
src/channel/channel.cairo
Outdated
| .channel_members | ||
| .read((channel_id, get_caller_address())); | ||
| assert(!channel_member.ban_status, BANNED_FROM_CHANNEL); | ||
| let mut channel: channelParams = self.channels.read(channel_id); |
There was a problem hiding this comment.
mint a channel token to the new member
src/channel/channel.cairo
Outdated
| .channel_members | ||
| .write( | ||
| (channel_id, get_caller_address()), | ||
| channelMember { |
There was a problem hiding this comment.
instantiate a new struct outside and pass in as a parameter. much cleaner that way
tests/test_channel.cairo
Outdated
| // not owner of the channel | ||
| #[test] | ||
| #[should_panic(expected: ('Channel: not channel owner',))] | ||
| fn test_set_channel_censorship_status_not_owner() { |
There was a problem hiding this comment.
rename to test_only_owner_can_set_censorship_status
tests/test_channel.cairo
Outdated
|
|
||
| // test for set_ban_status | ||
| #[test] | ||
| fn test_set_ban_status_owner() { |
There was a problem hiding this comment.
rename to simply test_set_ban_status
tests/test_channel.cairo
Outdated
|
|
||
| #[test] | ||
| #[should_panic(expected: ('Karst : Unauthorized access',))] | ||
| fn test_set_ban_status_owner_or_moderator() { |
There was a problem hiding this comment.
rename to test_only_owner_or_mod_can_set_ban_status
tests/test_channel.cairo
Outdated
|
|
||
| #[test] | ||
| #[should_panic(expected: ('Channel: not channel member',))] | ||
| fn test_set_ban_status_profile_is_not_member() { |
There was a problem hiding this comment.
rename to test_you_can_only_ban_channel_members
tests/test_channel.cairo
Outdated
| stop_cheat_caller_address(channel_contract_address); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
just seeing you added some tests for leaving and joining channels. please move them above and correct accordingly to the review i made above as regards joining and leaving channels
PavitraAgarwal21
force-pushed
the
main
branch
from
abbb714
to
7593588
Compare
No description provided.