Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aiomqtt #25

Merged
merged 9 commits into from
May 16, 2024
Merged

Migrate to aiomqtt #25

merged 9 commits into from
May 16, 2024

Conversation

hostcc
Copy link
Owner

@hostcc hostcc commented May 14, 2024

  • Migrated from asyncio-mqtt to aiomqtt in a straightforward way using __aenter__ and __aexit__ wrapping them into connect/disconnect methods of MqttClient class
  • Updated runtime and development packages to most recent versions
  • Github: Docker images are published on each workflow run to facilitate testing, not only when release is created

* Migrated from `asyncio-mqtt` to `aiomqtt` in a straightforward way
  using `__aenter__` and `__aexit__` instead of `connect`/`disconnect
  methods, plus removed overriding the latter ones since those have been
  removed from the base class
* Updated runtime and development packages to most recent versions
* Github: Docker images are published on each workflow run to facilitate
  testing, not only when release is created
@hostcc hostcc added the enhancement New feature or request label May 14, 2024
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

Copy link

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@hostcc hostcc self-assigned this May 14, 2024
Copy link

Copy link

@hostcc hostcc merged commit 10b2c3c into master May 16, 2024
10 checks passed
@hostcc hostcc deleted the feat-migrate-to-aiomqtt branch May 16, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant