feat: Typing hints, configuration file schema with pydantic
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added typing hints * Configuration file schema now uses `pydantic` instead of `schema`/`addict` - the former provides better typing support and more comprehensive schema definitions and validation * Requirements, both runtime and development, have been extracted into dedicated files (`requirements.txt` and `requirements_dev.txt`, respectively), so that other tools could be used to instantiate the environment * Added startup message listing the configuration parameters * `sphinx`: added support for automatic typing hints
|
Please retry analysis of this Pull-Request directly on SonarCloud |
vulnerability, as suggested by Snyk.
ARM platforms, they have been added to `build` stage
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
* Updated comments and copyright headers where missing
Dockerfile
Outdated
| RUN apk add -U cargo git rust \ | ||
| && pip install build \ | ||
| && apk cache clean | ||
| ADD . /usr/src/ |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources Low
|
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pydanticinstead ofschema/addict- the former provides better typing support and more comprehensive schema definitions and validationrequirements.txtandrequirements_dev.txt, respectively), so that other tools could be used to instantiate the environmentsphinx: added support for automatic typing hintsDockerfile: Rust and Cargo are required to buildpyndatic-coreon ARM platforms, they have been added tobuildstage