Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Upload Accepted Predictions #269

Merged
merged 10 commits into from
Sep 3, 2024
Merged

Conversation

kshitijrajsharma
Copy link
Member

@kshitijrajsharma kshitijrajsharma commented Sep 3, 2024

What does this PR do?

  • Allow users to upload accepted predictions
  • Introduce a new Dockerfile specifically designed for API usage

ApprovedPrediction Table

The new ApprovedPrediction table will have the following columns:

Column Name Description
training Training ID checkpoint used during prediction approval
config JSON field for storing configuration data (e.g., zoom level, vectorization parameters)
geom Geometry field supporting point, line, and polygon predictions
approved_at Automatic datetime field for approval timestamp

Note

No user information will be stored regarding who accepted the feature. Accepted features only be accepted if user decide to submit them with no user identification, Requires login in-order to push accepted features

Testing

To test the new functionality, ensure you have the following endpoints available:

Endpoints Screenshot

Additional Steps

  • Apply the necessary migration to complete the setup.

Thought Process

Thought process on designing this feature on fAIr is to enable us to store the accepted predictions made from fAIr so that later on it can be forwarded to tools / users as release . Once we have approved features on our db usecase will be widen , it can either be pushed to OSM , or be pushed to other platforms. This will also enable for other third party tools let user validate the fAIr predictions once they do they will push here . This feature supports the concept of turning mapper into validators

@omranlm
Copy link
Contributor

omranlm commented Sep 3, 2024

We need a migration for this change, right? and the check failed for migration

@kshitijrajsharma
Copy link
Member Author

We need a migration for this change, right? and the check failed for migration

Yes correct , I am trying to fix the CI before merging !

@kshitijrajsharma kshitijrajsharma merged commit 5d2d766 into master Sep 3, 2024
1 check passed
@kshitijrajsharma kshitijrajsharma deleted the feature/docker-api branch September 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants