Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX : Status code on the training publish endpoint #292

Merged
merged 2 commits into from
Oct 17, 2024
Merged

HOTFIX : Status code on the training publish endpoint #292

merged 2 commits into from
Oct 17, 2024

Conversation

kshitijrajsharma
Copy link
Member

@kshitijrajsharma kshitijrajsharma commented Oct 17, 2024 •
edited
Loading

What does this PR do ?

  • This PR fixes the status code on the training publish API endpoint
  • Adds user information on the training endpoint

Consideration :

I haven't looked in to other status code for other APIS atm , will fix those when development progresses , Kindly let me know !

How to test ?

  • When training is running it can't be published and you should get the 409 status code , Which is a conflict ( System is doing the training atm and can't be published )
  • 403 is used if training accuracy is less than 70 % , system understand the request but its forbidden to publish the training of low accuracy

@kshitijrajsharma kshitijrajsharma marked this pull request as ready for review October 17, 2024 10:08
omranlm
omranlm approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@omranlm omranlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and efficient .. thanks

@kshitijrajsharma kshitijrajsharma merged commit 03f002a into develop Oct 17, 2024
1 check passed
@kshitijrajsharma kshitijrajsharma deleted the hotfix/status-code-training branch October 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omranlm omranlm omranlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshitijrajsharma @omranlm