Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX : Status code on the training publish endpoint #292

Merged
merged 2 commits into from
Oct 17, 2024
Merged

HOTFIX : Status code on the training publish endpoint #292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1fb387
Fix : Fixes status code for the training publish
kshitijrajsharma Oct 17, 2024
558c24a
Add username in training endpoint
kshitijrajsharma Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/core/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class DatasetViewSet(
class TrainingSerializer(
serializers.ModelSerializer
): # serializers are used to translate models objects to api

user = UserSerializer(read_only=True)
multimasks = serializers.BooleanField(required=False, default=False)
input_contact_spacing = serializers.IntegerField(
required=False, default=8, min_value=0, max_value=20
Expand Down Expand Up @@ -729,10 +729,10 @@ def publish_training(request, training_id: int):
training_instance = get_object_or_404(Training, id=training_id)

if training_instance.status != "FINISHED":
return Response("Training is not FINISHED", status=404)
return Response("Training is not FINISHED", status=409)
if training_instance.accuracy < 70:
return Response(
"Can't publish the training since its accuracy is below 70%", status=404
"Can't publish the training since its accuracy is below 70%", status=403
)

model_instance = get_object_or_404(Model, id=training_instance.model.id)
Expand Down
Loading