Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX : Bypass permission for training accuracy graph download #293

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

kshitijrajsharma
Copy link
Member

@kshitijrajsharma kshitijrajsharma commented Oct 19, 2024

What does this PR do ?

  • Implements bypass logic to allow user downloading the accuracy graph without an authentication
  • Removes the pagination on banner endpoint
  • Implements caching on training-workspace view

Consideration :

I have bypassed the logic for accuracy graphs , this should allow user without an authentication to access the single file , however for other files it requires login still !
I am not fully confident on cache , server cache is not a best way to cache the training workspace view , I recommend cache on the frontend page itself ! However in-order to make user experience smooth and reduce frontend development load I have implemented the cache in server to the workspace view for now !

Later on , streaming EFS to endpoint will be more efficient than manually going through the folders from python , This can be added as enhancement for this endpoint , I am aware that this endpoint will not be efficient when training files keep growing on the server !

How to test ?

Try fetching the accuracy graph without an authentication it should work !

@kshitijrajsharma kshitijrajsharma marked this pull request as ready for review October 19, 2024 07:52
Copy link
Contributor

@omranlm omranlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great for ramp,
We might need to visit this again when we implement Yolo, depends on what graph we will have in Yolo

Copy link
Contributor

@omranlm omranlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@kshitijrajsharma kshitijrajsharma merged commit 154d9c0 into develop Oct 19, 2024
2 checks passed
@kshitijrajsharma kshitijrajsharma deleted the hotfix/training-graph-view-bypass branch October 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants