Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch : Security - Don't return task failure traceback to user #264

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

kshitijrajsharma
Copy link
Member

@kshitijrajsharma kshitijrajsharma commented Aug 9, 2024

What does this PR do ?

  • Avoids returning failure traceback to user

@kshitijrajsharma kshitijrajsharma marked this pull request as ready for review August 9, 2024 02:51
@kshitijrajsharma kshitijrajsharma merged commit 929a58b into develop Aug 9, 2024
5 checks passed
@kshitijrajsharma kshitijrajsharma deleted the hotfix/security-patch branch August 9, 2024 02:51
@spwoodcock
Copy link
Member

@kshitijrajsharma does this mean the only possible status returned is "SUCCESS"?

Do you think this might break the polling mechanism in osm-rawdata?
https://github.com/hotosm/osm-rawdata/blob/8848896ccde9554a2afd9a785bce511374612ed0/osm_rawdata/postgres.py#L575

@kshitijrajsharma
Copy link
Member Author

kshitijrajsharma commented Aug 9, 2024

@kshitijrajsharma does this mean the only possible status returned is "SUCCESS"?

Do you think this might break the polling mechanism in osm-rawdata?
https://github.com/hotosm/osm-rawdata/blob/8848896ccde9554a2afd9a785bce511374612ed0/osm_rawdata/postgres.py#L575

No , sorry about that . It will avoid returning reason of failure . It will still return status not the traceback . I mistakenly pushed traceback before while debugging

@spwoodcock
Copy link
Member

Oooh right, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants