Fixed: removed async from promise, improved logic for optimal code (#1)

hotwax · May 23, 2024 · 2ee0820 · 2ee0820
1 parent a8575ae
commit 2ee0820
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/views/AddConfigurations.vue b/src/views/AddConfigurations.vue
@@ -25,7 +25,7 @@
           <ion-item>
             <ion-icon slot="start" :icon="shirtOutline"/>
             <ion-select interface="popover" :label="translate('Product Identifier')" v-model="formData.productIdentifierEnumId">
-              <ion-select-option v-for="identifer in productIdentifiers" :key="identifer.enumId" :value="identifer.enumId">{{ identifer.description }}</ion-select-option>
+              <ion-select-option v-for="identifier in productIdentifiers" :key="identifier.enumId" :value="identifier.enumId">{{ identifier.description || identifier.enumId }}</ion-select-option>
             </ion-select>
           </ion-item>
 

diff --git a/src/views/CreateProductStore.vue b/src/views/CreateProductStore.vue
@@ -109,10 +109,10 @@ async function manageConfigurations() {
       
       if(!dbicCountriesCount.value) {
         const responses = await Promise.allSettled(selectedCountries.value
-        .map(async (country: any) => await ProductStoreService.updateDBICCountries({
-          geoId: country.geoId,
-          geoIdTo: "DBIC",
-          geoAssocTypeId: "GROUP_MEMBER"
+        .map((country: any) => ProductStoreService.updateDBICCountries({
+            geoId: country.geoId,
+            geoIdTo: "DBIC",
+            geoAssocTypeId: "GROUP_MEMBER"
           }))
         )
         

diff --git a/src/views/ProductStoreDetails.vue b/src/views/ProductStoreDetails.vue
@@ -24,7 +24,7 @@
               <ion-item>
                 <ion-icon :icon="mapOutline" slot="start"/>
                 <ion-label>{{ translate("Operating in") }}</ion-label>
-                <ion-label slot="end">{{ dbicCountriesCount > 1 ? translate("countries", {count: dbicCountriesCount}) : translate("country", {count: dbicCountriesCount}) }}</ion-label>
+                <ion-label slot="end">{{  translate(dbicCountriesCount > 1 || dbicCountriesCount == 0 ? "countries" : "country", {count: dbicCountriesCount}) }}</ion-label>
               </ion-item>
 
               <ion-item>