add validation to the code #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i tried to resolve the error by adding the isValidOMS function in the action. partially resolved the issue . |
ymaheshwari1
requested changes
Nov 9, 2023
| @@ -31,9 +34,26 @@ export const useAuthStore = defineStore('authStore', { | |||
| return baseURL.startsWith('http') ? baseURL : `https://${baseURL}.hotwax.io/api/` | |||
| }, | |||
| getRedirectUrl: (state) => state.redirectUrl, | |||
|
|
|||
| isValidOMS(oms)=>{ | |||
| if(oms === "dev-apps"){ | |||
There was a problem hiding this comment.
Here we have hardcoded the oms value, but then this condition will always return false if we have used any other oms which is not correct.
Need to have some robust solution that can handle all the oms and we also don't need to hardcode oms names for checking.
|
Closing as need to find some solution that can handle all the oms instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance