Improved: added spinner in launchpad login next button to be shown while checkLoginOption request accomplishes (#88) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile checkLoginOption request accomplishes (hotwax#88)
ymaheshwari1
requested changes
Mar 20, 2024
src/views/Login.vue
Outdated
| @@ -108,7 +113,8 @@ export default defineComponent({ | |||
| hideBackground: true, | |||
| isConfirmingForActiveSession: false, | |||
| loader: null as any, | |||
| loginOption: {} as any | |||
| loginOption: {} as any, | |||
| isSpinnerActive: false | |||
There was a problem hiding this comment.
Suggested change
| isSpinnerActive: false | |
| isLoading: false |
amansinghbais
requested review from
ymaheshwari1
and removed request for
ymaheshwari1
ymaheshwari1
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #88
Short Description and Why It's Useful
Implemented spinner inside of the next button in login page to be displayed until checkLoginOptions request is ongoing.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance