Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended the description in the incoming shipment creation flow #919

Open
wants to merge 2 commits into
base: implementations-pub
Choose a base branch
from

Conversation

Chinmay2107
Copy link

No description provided.

@dt2patel dt2patel requested a review from toaditi December 5, 2024 11:25
Copy link
Collaborator

@toaditi toaditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few edits that will bring this document up to date. Added comments accordingly.


2. **Fulfilling Transfer Orders**
- The store fulfills these accepted Transfer Orders and creates shipments for them with `"shipmentTypeId": "OUT_TRANSFER"`.
- This process already exists in HotWax OMS.
- **Note**: More detail is required on this process.

3. **Scheduled Job for Outgoing Transfers**
- A scheduled job will be created to pull all new `"OUT_TRANSFER"` shipments in the `"PURCH_SHIP_SHIPPED"` status.
- These shipments will be placed at an SFTP location for further processing.
- **Note**: The format of this file needs to be identified. Ideally, it should match the format used by the existing jobs. This is JSON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line can also be deleted.


3. **Scheduled Job for Outgoing Transfers**
- A scheduled job will be created to pull all new `"OUT_TRANSFER"` shipments in the `"PURCH_SHIP_SHIPPED"` status.
- These shipments will be placed at an SFTP location for further processing.
- **Note**: The format of this file needs to be identified. Ideally, it should match the format used by the existing jobs. This is JSON
- **Note**: This job may be helpful here `generate_TransferOrderFulfilledItemsFeed"`
- **Note**: The`generate_TransferOrderFulfilledItemsFeed"` service generates the feed in JSON format.

4. **Using NiFi to Create Incoming Transfers**
- A NiFi flow will be created to process the files placed at the SFTP location.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NiFi has been created and tested. Details of the flow should be added here.

@@ -31,7 +30,7 @@ This document highlights how Transfer Orders (TOs) will be managed after a recom
- The file created by NiFi will be uploaded into OMS using configID: `IMP_SHIPMENT` and job: `createIncomingShipment`

### JOLT Transformation for Incoming Transfers
The following JOLT transformation is used create the new `"IN_TRANSFER"` shipment:
The following JOLT transformation is used to create the new `"IN_TRANSFER"` shipment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a part of the NiFi flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants