Skip to content

Commit

Permalink
Improved: workflow for PR check and added issue and pr templates
Browse files Browse the repository at this point in the history
  • Loading branch information
ymaheshwari1 committed Dec 29, 2023
1 parent 00eefa6 commit 5cab0e1
Show file tree
Hide file tree
Showing 4 changed files with 80 additions and 26 deletions.
31 changes: 31 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
name: Bug report
about: report to help us improve
labels: bug
---

## Current behavior
<!-- Describe the current behavior pointing exactly why it's not working as intended. -->


## Expected behavior
<!-- Describe what the desired behavior should be. -->


## Steps to reproduce the issue
<!-- Please provide the steps to reproduce and if possible a *minimal reproducible example* of the problem -->


## Can you handle fixing this bug by yourself?

- [ ] YES
- [ ] NO

## Environment details
<!-- Please provide all the informations required below. -->
- Browser: <!-- Your browser, version -->
- OS: <!-- Your operating system, version -->
- Code Version: <!-- Tag, branch or commit determining which version of code is used -->

## Additional information
<!-- If you think that any additional information would be useful, please provide them here. -->
23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Feature request
about: Suggest an idea for this project
labels: feature request

---

## What is the motivation for adding/enhancing this feature?
<!-- Describe the motivation or the concrete use case for a new feature or why one of the current ones should be enhanced. -->


## What are the acceptance criteria?
<!-- List the acceptance criteria for this task in the form of a list. -->

- [ ] ...

## Can you complete this feature request by yourself?

- [ ] YES
- [ ] NO

## Additional information
<!-- If you think that any additional information would be useful, please provide them here. -->
17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
### Related Issues
<!-- Put related issue number which this PR is closing. For example #123 -->

Closes #

### Short Description and Why It's Useful
<!-- Describe in a few words what is this Pull Request changing and why it's useful -->


### Screenshots of Visual Changes before/after (If There Are Any)
<!-- If you made any changes in the UI layer, please provide before/after screenshots -->


### Contribution and Currently Important Rules Acceptance
<!-- Please get familiar with following info -->

- [ ] I read and followed [contribution rules](https://github.com/hotwax/order-routing-rules#contribution-guideline)
35 changes: 9 additions & 26 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,15 @@ name: Verify build

on:
push:
branches: [ main ]
branches: [main]
pull_request:
# The branches below must be a subset of the branches above
branches: [ main ]

branches: [main]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]

steps:
- uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}


- name: Install Dependencies
run: npm install
- name: Generate .env file
run: cp .env.example .env
- name: Build
run: npm run build
jobs:
call-workflow-in-another-repo:
uses: hotwax/dxp-components/.github/workflows/common-pull-request.yml@main
with:
config-path: .github/labeler.yml
secrets:
envPAT: ${{ secrets.envPAT }}

0 comments on commit 5cab0e1

Please sign in to comment.