Improved: Show Completed Shipments Along with Open Shipments (#380) #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Aug 13, 2024
| @media (min-width: 991px) { | ||
| ion-header > div { | ||
| display: flex; |
There was a problem hiding this comment.
@amansinghbais why not use the same pattern as job manager?
There was a problem hiding this comment.
@dt2patel sir, The same pattern was used in the pipeline page of Job Manager app. Took reference from there only.
| @@ -104,7 +122,7 @@ export default defineComponent({ | |||
| const payload = { | |||
| "inputFields": { | |||
| "destinationFacilityId": this.user.facilityId, | |||
| "statusId": "PURCH_SHIP_SHIPPED", | |||
| "statusId": this.selectedSegment === "open" ? "PURCH_SHIP_SHIPPED" : "PURCH_SHIP_RECEIVED", | |||
There was a problem hiding this comment.
Should this be available on all pages instead of just the shipments page? I think so right? @amansinghbais
There was a problem hiding this comment.
Yes, we can extend this approach to other pages as well to ensure consistency across the application. Initially, the implementation was focused on the shipment page as discussed, but we can apply the same for other pages as well.
…ails page respectively (hotwax#380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#380
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
Contribution and Currently Important Rules Acceptance