-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved: Show Completed Shipments Along with Open Shipments (#380) #381
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comments
@media (min-width: 991px) { | ||
ion-header > div { | ||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amansinghbais why not use the same pattern as job manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dt2patel sir, The same pattern was used in the pipeline page of Job Manager app. Took reference from there only.
@@ -104,7 +122,7 @@ export default defineComponent({ | |||
const payload = { | |||
"inputFields": { | |||
"destinationFacilityId": this.user.facilityId, | |||
"statusId": "PURCH_SHIP_SHIPPED", | |||
"statusId": this.selectedSegment === "open" ? "PURCH_SHIP_SHIPPED" : "PURCH_SHIP_RECEIVED", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be available on all pages instead of just the shipments page? I think so right? @amansinghbais
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can extend this approach to other pages as well to ensure consistency across the application. Initially, the implementation was focused on the shipment page as discussed, but we can apply the same for other pages as well.
…ails page respectively (hotwax#380)
Related Issues
#380
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
Contribution and Currently Important Rules Acceptance