Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: Receive shipment enhancement (#402). #391

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improved: Receive shipment enhancement (#402). #391

wants to merge 6 commits into from

Conversation

ravilodhi
Copy link
Contributor

@ravilodhi ravilodhi commented Oct 11, 2024 •
edited
Loading

Related Issues

#402

Short Description and Why It's Useful

Done following-

  1. Used json file upload for receiving shipment items in a single call instead of calling apis multiple times to receive items.
  2. Updated Shipment, Return and PO receiving according to the first point.
  3. Used createIncomingShipment api to create shipment and items in a single call instead of making multiple api calls for adding shipment items.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@ravilodhi ravilodhi changed the title Improved: Used MDM(Uploading json file) to receive items. Draft: Improved: Used MDM(Uploading json file) to receive items. Oct 11, 2024
@ravilodhi
Removed: unused code.
c38915f
@ravilodhi
Merge branch 'main' of https://github.com/hotwax/receiving into recei…
4939910 
…ve_shipment
@ravilodhi
Improved: Added checks to allow receiving of items if it was not rece…
63d344b 
…ived earlier. This is helpful when some of the items got failed and allowed to receive the remaining items.
@ravilodhi ravilodhi changed the title Draft: Improved: Used MDM(Uploading json file) to receive items. Improved: Used MDM(Uploading json file) to receive items (#402). Oct 16, 2024
@ravilodhi
Copy link
Contributor Author

ravilodhi commented Oct 16, 2024 •
edited
Loading

Some fixes are done in the upload uploadAndImportFile so these changes are OMS dependant. Need 5.18.0 release.

@ravilodhi
Improved: Used createIncomingShipment service to create shipment with…
b201629 
… items instead of doing multiple calls for creating/adding shipment and items. Also used the common flow for shipment, return and po to import the json file and processing the item receiving at backend. (#402)
@ravilodhi
Merge branch 'main' of https://github.com/hotwax/receiving into recei…
3f6a475 
…ve_shipment
@ravilodhi ravilodhi changed the title Improved: Used MDM(Uploading json file) to receive items (#402). Improved: Receive shipment enhancement (#402). Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ravilodhi