Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Alert message when removing the Security Group from user detail page.(#305) #306

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Improved: Alert message when removing the Security Group from user detail page.(#305) #306

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b3e568
Improved: Better alert message when removing the Security Group (#305)
priyanshee1604 Jan 15, 2025
805fff5
Improved: Changed the backticks to inverted commas. (#305)
priyanshee1604 Jan 15, 2025
8aa6473
Improved: Toast message now includes the username (hotwax#305)
priyanshee1604 Jan 16, 2025
56cce9e
Revert "Improved: Toast message now includes the username (hotwax#305)"
priyanshee1604 Jan 16, 2025
51d8f18
Improved: Toast message now includes the username.(#305)
priyanshee1604 Jan 16, 2025
222b5b2
Improved: Indentation adjusted for better readability.
priyanshee1604 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/SecurityGroupActionsPopover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,17 @@
this.closePopover(userSecurityGroups)
},
async confirmRemove() {
const message = 'Are you sure you want to perform this action?'
const username = this.selectedUser.groupName ? this.selectedUser.groupName: this.selectedUser.firstName +' '+ this.selectedUser.lastName
ymaheshwari1 marked this conversation as resolved.
Show resolved Hide resolved
const message = "Removing this security group may limit 's access to certain features or data. Are you sure you want to continue?"
const alert = await alertController.create({
header: translate("Remove security group"),
message: translate(message),
message: translate(message, { username }),
buttons: [
{
text: translate("No"),
text: translate("Keep Group"),
},
{
text: translate("Yes"),
text: translate("Remove"),
handler: async () => {
await this.removeUserSecurityGroup();
}
Expand Down
2 changes: 2 additions & 0 deletions src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@
"Internal ID cannot be more than 20 characters.": "Internal ID cannot be more than 20 characters.",
"Invalid email address.": "Invalid email address.",
"is ready to login": "{userLoginId} is ready to login.",
"Keep Group":"Keep Group",
"Language": "Language",
"Last name": "Last name",
"Last name is required.": "Last name is required.",
Expand Down Expand Up @@ -163,6 +164,7 @@
"Remove phone number": "Remove phone number",
"Remove product store": "Remove product store",
"Remove users": "Remove users",
"Removing this security group may limit 's access to certain features or data. Are you sure you want to continue?": "Removing this security group may limit {username}'s access to certain features or data. Are you sure you want to continue?",
"Rename Security Group": "Rename Security Group",
"Require password reset on login": "Require password reset on login",
"Reset password": "Reset password",
Expand Down
Loading