Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking API change: applications can set a User-Agent prefix #77

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Breaking API change: applications can set a User-Agent prefix #77

merged 2 commits into from
Dec 16, 2024

Conversation

jayohms
Copy link
Contributor

@jayohms jayohms commented Dec 12, 2024

This resolves issues like these:

Applications can now set a custom applicationUserAgentPrefix for their application via:

Hotwire.config.applicationUserAgentPrefix = "My Application Prefix"

Whenever a WebView instance is created, the library will now automatically include:

  • Your (optional) custom applicationUserAgentPrefix
  • "Hotwire Native Android; Turbo Native Android;"
  • "bridge-components: [your bridge components];"
  • The WebView's default Chromium user agent string

Since this a breaking API change, we'll include this is in an upcoming v1.1 release.

@jayohms
Breaking API change: only allow apps to set a User-Agent prefix to re…
b7794de 
…move error-prone situations where an application wasn't including the Hotwire substring in their custom user agnet.
@joemasilotti joemasilotti mentioned this pull request Dec 12, 2024
Merged
@jayohms jayohms merged commit 7155a66 into main Dec 16, 2024
1 check passed
@jayohms jayohms deleted the user-agent-prefix branch December 16, 2024 15:26
This was referenced Dec 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayohms