Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters in route #46

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

harshalbhakta
Copy link
Contributor

parameters argument is missing here. This causes parameters not being retained in handle(proposal: VisitProposal).

// For example, parameters passed in below function call
navigator.route(
    rootUrl.appendingPathComponent("/auth/enter-otp"),
    options: VisitOptions(action: .advance),
    parameters: ["mobileNumber": enternedMobileNumber]
)
 
extension SceneDelegate: NavigatorDelegate {
    func handle(proposal: VisitProposal) -> ProposalResult {
       // are not received here in proposal.parameters
    }
}

It was added in this commit but removed in this commit. I think this was mistakenly removed.

@joemasilotti
Copy link
Member

joemasilotti commented Nov 12, 2024

Great catch, thanks for the contribution! Will merge after CI runs.

@joemasilotti joemasilotti merged commit f36ec68 into hotwired:main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants