Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document view transitions #158

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Document view transitions #158

merged 7 commits into from
Feb 7, 2024

Conversation

afcapel
Copy link
Contributor

@afcapel afcapel commented Jan 25, 2024

domchristie
domchristie reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@domchristie domchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this. I wonder if it would be helpful to add this to the attributes reference too: https://github.com/hotwired/turbo-site/blob/main/_source/reference/attributes.md

_source/handbook/02_drive.md Outdated Show resolved Hide resolved
@afcapel
Copy link
Contributor Author

afcapel commented Jan 26, 2024

I wonder if it would be helpful to add this to the attributes reference too

Good point, added in 86b5423

domchristie
domchristie reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@domchristie domchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing: I think we could add <meta name="view-transition" content="same-origin" /> to the meta tags reference. (Sorry to nit-pick!)

_source/reference/attributes.md Outdated Show resolved Hide resolved
afcapel and others added 2 commits January 26, 2024 10:58
kevinmcconnell
kevinmcconnell approved these changes Jan 30, 2024
View reviewed changes
_source/handbook/02_drive.md Outdated Show resolved Hide resolved
afcapel and others added 2 commits January 31, 2024 20:12
@afcapel @kevinmcconnell
Clarify it’s optional
99dfc92 
Co-authored-by: Kevin McConnell <[email protected]>
@afcapel
Merge remote-tracking branch 'origin/main' into document-view-transit…
e6fe03e 
…ions

* origin/main:
  Document Instaclick (#157)
  Document page refreshes with morphing (#160)
  Document Morph events
  Add `[id]` to `<turbo-frame>` in Promotion example (#156)
  Update - Correct typo in 04_streams.md (#155)
  Update urls (#154)
  Fix a typo in the breaking out from a frame section
@afcapel afcapel merged commit ccb5744 into main Feb 7, 2024
@afcapel afcapel deleted the document-view-transitions branch February 7, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmcconnell kevinmcconnell kevinmcconnell approved these changes

@domchristie domchristie domchristie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afcapel @domchristie @kevinmcconnell