Refactor head_snapshot #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
Dec 28, 2022
seanpdoyle
reviewed
Dec 28, 2022
seanpdoyle
reviewed
Dec 28, 2022
|
Sean's recommendations bring the minimized package size down further to 71.79k or 1.36% smaller. |
|
@seanpdoyle Tried once more to implement the grouping by class, but couldn't get typescript to accept my various attempts to generic-tize the elements array. Would you be able to take a stab at it? Or can we consider merging this branch to realize the size & speed benefits for now, and attempt to make further optimizations later. |
|
Bump for attention. |
|
Typescript removed. Ready to go and a great candidate for Turbo 8. Looking for review and approval. |
|
Not planning on helping here too much, but I think your test is still in TS |
|
Tests updated. Ready for review. |
|
Verified: works great in Turbo 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies head_snapshot to sort elements by type as the snapshot is created resulting in less code, a more compact minimized codebase, and increased performance.
The current head snapshot comparison method compares all items in the header against themselves. This branch compares scripts to scripts, styles to styles, meta to meta, and so on. This allows for more efficient processing of items during merge. The primary benefit to this refactor is how it affects the size of the Turbo library - reducing the size of the minified code base by 1.3% (72.78k -> 71.84k).