Fix donations for Houdini #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwahammy
force-pushed
the
fix/donation-working
branch
from
3481fec to
0d6b099
Compare
wwahammy
force-pushed
the
fix/donation-working
branch
3 times, most recently
from
d4fd744 to
32a9f9e
Compare
|
This PR/issue depends on: |
wwahammy
force-pushed
the
fix/donation-working
branch
from
aa73ce6 to
5f3da93
Compare
|
@clarissalimab, I'm rerequesting review because I made a few more changes. I doubt it has any real effect on the end result but please look them over since I THINK this is passing... we'll see in a few minutes i guess! |
|
🎆 |
clarissalimab
approved these changes
Apr 13, 2022
|
Brilliant! Thanks @clarissalimab and @wwahammy for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of interconnected issues with the donation system. This is a quick fix for them but there are additional ones I am sure.
This seems to work on the pretty path but not quite sure how badly it works when there are errors
Depends on #1065
Depends on #1064