Make Ubi struct implement Send and Sync again

I did this for backwards compatibility.
houseabsolute · Dec 26, 2024 · 7be5bf3 · 7be5bf3
1 parent 3dd0d22
commit 7be5bf3
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/ubi/src/builder.rs b/ubi/src/builder.rs
@@ -193,7 +193,11 @@ impl<'a> UbiBuilder<'a> {
         ))
     }
 
-    fn new_forge(&self, project_name: String, forge_type: &ForgeType) -> Result<Box<dyn Forge>> {
+    fn new_forge(
+        &self,
+        project_name: String,
+        forge_type: &ForgeType,
+    ) -> Result<Box<dyn Forge + Send + Sync>> {
         let api_base = self.api_base_url.map(Url::parse).transpose()?;
         Ok(match forge_type {
             ForgeType::GitHub => Box::new(GitHub::new(

diff --git a/ubi/src/github.rs b/ubi/src/github.rs
@@ -21,6 +21,9 @@ pub(crate) struct GitHub {
     token: Option<String>,
 }
 
+unsafe impl Send for GitHub {}
+unsafe impl Sync for GitHub {}
+
 #[derive(Debug, Deserialize, Serialize)]
 pub(crate) struct Release {
     pub(crate) assets: Vec<Asset>,

diff --git a/ubi/src/gitlab.rs b/ubi/src/gitlab.rs
@@ -18,6 +18,9 @@ pub(crate) struct GitLab {
     token: Option<String>,
 }
 
+unsafe impl Send for GitLab {}
+unsafe impl Sync for GitLab {}
+
 #[derive(Debug, Deserialize, Serialize)]
 struct Release {
     assets: GitLabAssets,

diff --git a/ubi/src/ubi.rs b/ubi/src/ubi.rs
@@ -14,7 +14,7 @@ use url::Url;
 /// [`UbiBuilder`](crate::UbiBuilder) struct to create a new `Ubi` instance.
 #[derive(Debug)]
 pub struct Ubi<'a> {
-    forge: Box<dyn Forge>,
+    forge: Box<dyn Forge + Send + Sync>,
     asset_url: Option<Url>,
     asset_picker: AssetPicker<'a>,
     installer: Installer,
@@ -38,7 +38,7 @@ pub(crate) struct Download {
 impl<'a> Ubi<'a> {
     /// Create a new Ubi instance.
     pub(crate) fn new(
-        forge: Box<dyn Forge>,
+        forge: Box<dyn Forge + Send + Sync>,
         asset_url: Option<Url>,
         asset_picker: AssetPicker<'a>,
         installer: Installer,