[CLEANUP]: Improve readability, Fix potential Overflow(Maximum 10 bytes for a 64-bit number) #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for a 64-bit number)
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
============================================
- Coverage 63.40% 63.39% -0.01%
Complexity 1279 1279
============================================
Files 138 138
Lines 6760 6761 +1
Branches 522 522
============================================
Hits 4286 4286
- Misses 2205 2206 +1
Partials 269 269
|
sundy-li
approved these changes
Sep 4, 2023
BENCHMARK_REPORT1. Benchmark (batchSize) (columnNum) (selectNumber) Mode Cnt Score Error Units 2. DoubleIBenchmark.benchInsertJdbc 200000 20 N/A avgt 211.712 ms/op 3. DoubleIBenchmark.benchInsertJdbc 200000 50 N/A avgt 501.991 ms/op 4. DoubleIBenchmark.benchInsertJdbc 500000 20 N/A avgt 504.494 ms/op 5. DoubleIBenchmark.benchInsertJdbc 500000 50 N/A avgt 1303.933 ms/op 6. DoubleIBenchmark.benchInsertNative 200000 20 N/A avgt 374.279 ms/op 7. DoubleIBenchmark.benchInsertNative 200000 50 N/A avgt 948.756 ms/op 8. DoubleIBenchmark.benchInsertNative 500000 20 N/A avgt 916.431 ms/op 9. DoubleIBenchmark.benchInsertNative 500000 50 N/A avgt 2296.309 ms/op 10. InsertIBenchmark.benchInsertJdbc 200000 20 N/A avgt 164.017 ms/op 11. InsertIBenchmark.benchInsertJdbc 200000 50 N/A avgt 167.156 ms/op 12. InsertIBenchmark.benchInsertJdbc 500000 20 N/A avgt 363.243 ms/op 13. InsertIBenchmark.benchInsertJdbc 500000 50 N/A avgt 359.906 ms/op 14. InsertIBenchmark.benchInsertNative 200000 20 N/A avgt 103.740 ms/op 15. InsertIBenchmark.benchInsertNative 200000 50 N/A avgt 105.290 ms/op 16. InsertIBenchmark.benchInsertNative 500000 20 N/A avgt 247.799 ms/op 17. InsertIBenchmark.benchInsertNative 500000 50 N/A avgt 247.052 ms/op 18. IntIBenchmark.benchInsertJdbc 200000 20 N/A avgt 175.245 ms/op 19. IntIBenchmark.benchInsertJdbc 200000 50 N/A avgt 390.457 ms/op 20. IntIBenchmark.benchInsertJdbc 500000 20 N/A avgt 380.757 ms/op 21. IntIBenchmark.benchInsertJdbc 500000 50 N/A avgt 985.624 ms/op 22. IntIBenchmark.benchInsertNative 200000 20 N/A avgt 329.321 ms/op 23. IntIBenchmark.benchInsertNative 200000 50 N/A avgt 801.363 ms/op 24. IntIBenchmark.benchInsertNative 500000 20 N/A avgt 785.290 ms/op 25. IntIBenchmark.benchInsertNative 500000 50 N/A avgt 2015.161 ms/op 26. SelectIBenchmark.benchSelectJdbc N/A N/A 500000 avgt 336.959 ms/op 27. SelectIBenchmark.benchSelectJdbc N/A N/A 10000000 avgt 5925.599 ms/op 28. SelectIBenchmark.benchSelectNative N/A N/A 500000 avgt 290.935 ms/op 29. SelectIBenchmark.benchSelectNative N/A N/A 10000000 avgt 5417.224 ms/op 30. StringIBenchmark.benchInsertJdbc 200000 20 N/A avgt 506.145 ms/op 31. StringIBenchmark.benchInsertJdbc 200000 50 N/A avgt 1319.373 ms/op 32. StringIBenchmark.benchInsertJdbc 500000 20 N/A avgt 1239.655 ms/op 33. StringIBenchmark.benchInsertJdbc 500000 50 N/A avgt 3255.456 ms/op 34. StringIBenchmark.benchInsertNative 200000 20 N/A avgt 605.711 ms/op 35. StringIBenchmark.benchInsertNative 200000 50 N/A avgt 1564.937 ms/op 36. StringIBenchmark.benchInsertNative 500000 20 N/A avgt 1465.961 ms/op 37. StringIBenchmark.benchInsertNative 500000 50 N/A avgt 3782.372 ms/op 38. WideColumnDoubleInsertIBenchmark.benchInsertJdbc 200000 20 N/A avgt 199.658 ms/op 39. WideColumnDoubleInsertIBenchmark.benchInsertJdbc 200000 50 N/A avgt 497.024 ms/op 40. WideColumnDoubleInsertIBenchmark.benchInsertJdbc 500000 20 N/A avgt 518.366 ms/op 41. WideColumnDoubleInsertIBenchmark.benchInsertJdbc 500000 50 N/A avgt 1367.081 ms/op 42. WideColumnDoubleInsertIBenchmark.benchInsertNative 200000 20 N/A avgt 449.362 ms/op 43. WideColumnDoubleInsertIBenchmark.benchInsertNative 200000 50 N/A avgt 939.349 ms/op 44. WideColumnDoubleInsertIBenchmark.benchInsertNative 500000 20 N/A avgt 920.718 ms/op 45. WideColumnDoubleInsertIBenchmark.benchInsertNative 500000 50 N/A avgt 2302.104 ms/op 46. WideColumnIntInsertIBenchmark.benchInsertJdbc 200000 20 N/A avgt 165.219 ms/op 47. WideColumnIntInsertIBenchmark.benchInsertJdbc 200000 50 N/A avgt 393.349 ms/op 48. WideColumnIntInsertIBenchmark.benchInsertJdbc 500000 20 N/A avgt 376.509 ms/op 49. WideColumnIntInsertIBenchmark.benchInsertJdbc 500000 50 N/A avgt 900.630 ms/op 50. WideColumnIntInsertIBenchmark.benchInsertNative 200000 20 N/A avgt 325.058 ms/op 51. WideColumnIntInsertIBenchmark.benchInsertNative 200000 50 N/A avgt 800.771 ms/op 52. WideColumnIntInsertIBenchmark.benchInsertNative 500000 20 N/A avgt 787.190 ms/op 53. WideColumnIntInsertIBenchmark.benchInsertNative 500000 50 N/A avgt 2346.778 ms/op 54. WideColumnStringInsertIBenchmark.benchInsertJdbc 200000 20 N/A avgt 502.618 ms/op 55. WideColumnStringInsertIBenchmark.benchInsertJdbc 200000 50 N/A avgt 1318.827 ms/op 56. WideColumnStringInsertIBenchmark.benchInsertJdbc 500000 20 N/A avgt 1222.979 ms/op 57. WideColumnStringInsertIBenchmark.benchInsertJdbc 500000 50 N/A avgt 3186.275 ms/op 58. WideColumnStringInsertIBenchmark.benchInsertNative 200000 20 N/A avgt 603.898 ms/op 59. WideColumnStringInsertIBenchmark.benchInsertNative 200000 50 N/A avgt 1575.802 ms/op 60. WideColumnStringInsertIBenchmark.benchInsertNative 500000 20 N/A avgt 1573.803 ms/op 61. WideColumnStringInsertIBenchmark.benchInsertNative 500000 50 N/A avgt 3924.321 ms/op |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.