Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL improvements #1430

Merged
merged 4 commits into from
Feb 4, 2024
Merged

RTL improvements #1430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c761eed
Fix RTL sound preview icon positioning
hovancik Feb 1, 2024
19818de
Fix menu options sometimes not being translated
hovancik Feb 1, 2024
6f36e07
Fixes RTL navigation
hovancik Feb 4, 2024
911d290
RTL select improvements
hovancik Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed
- transparency issues on Windows 10
- Schedule options not being updated after change of language
- Schedule and Menu options not being updated after change of language
- multiple RTL UI issues

## [1.15.1] - 2023-11-19
### Fixed
Expand Down
14 changes: 13 additions & 1 deletion app/css/commons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ a {

/* https://css-tricks.com/html5-progress-element/ */
progress {
appearance: none;
-webkit-appearance: none;
height: 6px;
width: min(50vw, 50vh);
Expand Down Expand Up @@ -328,6 +329,11 @@ body[dir=rtl] .has-select {
right: 3px;
}

body[dir=rtl] .has-select::after {
left: 3px;
right: auto;
}

.has-select::before {
background: var(--has-select-before-bg);
border-radius: 0 3px 3px 0;
Expand All @@ -339,7 +345,13 @@ body[dir=rtl] .has-select {
width: 16.5px;
}

body[dir=rtl] .has-select::before {
left: 0;
right: auto;
}

select {
appearance: none;
-webkit-appearance: none;
color: var(--select-color);
background: var(--select-bg);
Expand All @@ -354,7 +366,7 @@ select {

body[dir=rtl] select {
padding-left: 0;
padding-right: 20px;
padding-right: 8px;
}

select option {
Expand Down
5 changes: 5 additions & 0 deletions app/css/preferences.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,11 @@ body[dir=rtl] .theme > :nth-child(17) {
padding-left: 15px;
}

body[dir=rtl] .sounds > img {
padding-left: 0;
padding-right: 15px;
}

.about {
display: grid;
font-size: 13px;
Expand Down
2 changes: 1 addition & 1 deletion app/preferences.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<link rel="stylesheet" type="text/css" href="css/preferences.css">
</head>
<body>
<nav class="navigation" dir="ltr">
<nav class="navigation">
<a href="#" class="active" data-section="settings">
<div>
<img src="images/preferences/settings.svg">
Expand Down
1 change: 1 addition & 0 deletions app/preferences.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ window.onload = (e) => {
document.querySelector('#longBreakEvery').closest('div').querySelector('output')
.innerHTML = i18next.t('utils.minutes', { count: parseInt(realBreakInterval()) })
})
htmlTranslate.translate() // sometimes few texts are not translated, so calling twice
setWindowHeight()
}
}
Expand Down
Loading