Fix infinite recursive loop in BVH building (#81)

When all primitive centroids are equal during a recursive BVH building step, it results in a recursive loop. This fix detects this case and returns a leaf node instead. Co-authored-by: Tom Janssens <[email protected]>
hoverinc · Apr 21, 2020 · 0324fef · 0324fef
1 parent e6d951c
commit 0324fef
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/renderer/bvhAccel.js b/src/renderer/bvhAccel.js
@@ -149,6 +149,10 @@ function recursiveBuild(primitiveInfo, start, end) {
     }
     const dim = maximumExtent(centroidBounds);
 
+    if (centroidBounds.max[dim] === centroidBounds.min[dim]) {
+      return makeLeafNode(primitiveInfo.slice(start, end), bounds);
+    }
+
     let mid = Math.floor((start + end) / 2);
 
     // middle split method