Removed checking for valid tx pin for Victron (#455)

Please check wiki documentation, and change/extend it accordingly.
hoylabs · Sep 28, 2023 · 4ee49a6 · 4ee49a6
1 parent 933345d
commit 4ee49a6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/PinMapping.cpp b/src/PinMapping.cpp
@@ -307,8 +307,7 @@ bool PinMappingClass::isValidEthConfig()
 
 bool PinMappingClass::isValidVictronConfig()
 {
-    return _pinMapping.victron_rx >= 0
-        && _pinMapping.victron_tx >= 0;
+    return _pinMapping.victron_rx >= 0;
 }
 
 bool PinMappingClass::isValidHuaweiConfig()

diff --git a/src/VictronSmartShunt.cpp b/src/VictronSmartShunt.cpp
@@ -13,7 +13,7 @@ bool VictronSmartShunt::init(bool verboseLogging)
     MessageOutput.printf("[VictronSmartShunt] Interface rx = %d, tx = %d\r\n",
             pin.battery_rx, pin.battery_tx);
 
-    if (pin.battery_rx < 0 || pin.battery_tx < 0) {
+    if (pin.battery_rx < 0) {
         MessageOutput.println(F("[VictronSmartShunt] Invalid pin config"));
         return false;
     }