remove timestamp bug

hoylabs · Sep 1, 2024 · e5a2312 · e5a2312
1 parent bbd5c26
commit e5a2312
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/include/VictronSmartBatterySense.h b/include/VictronSmartBatterySense.h
@@ -11,8 +11,6 @@ class VictronSmartBatterySense : public BatteryProvider {
     std::shared_ptr<BatteryStats> getStats() const final { return _stats; }
 
 private:
-    // static char constexpr _serialPortOwner[] = "SmartBatterySense";
-
     uint32_t _lastUpdate = 0;
     std::shared_ptr<VictronSmartBatterySenseStats> _stats =
         std::make_shared<VictronSmartBatterySenseStats>();

diff --git a/src/BatteryStats.cpp b/src/BatteryStats.cpp
@@ -617,8 +617,9 @@ void VictronSmartShuntStats::mqttPublish() const {
 void VictronSmartBatterySenseStats::updateFrom(uint32_t volt, int32_t temp, uint32_t timeStamp) {
 
     // we just get battery voltage and temperature from the "Smart Battery Sense" device
-    BatteryStats::setVoltage(volt/ 1000.0f, timeStamp);
+    BatteryStats::setVoltage(volt / 1000.0f, timeStamp);
     _temperature = temp / 1000.0f;
+    _manufacturer = "Smart Battery Sense";
 }
 
 void VictronSmartBatterySenseStats::getLiveViewData(JsonVariant& root) const {

diff --git a/src/VictronSmartBatterySense.cpp b/src/VictronSmartBatterySense.cpp
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-
 #include "VictronMppt.h"
 #include "MessageOutput.h"
 #include "VictronSmartBatterySense.h"
@@ -36,10 +35,10 @@ void VictronSmartBatterySense::loop()
         if ((mpptData->SmartBatterySenseTemperatureMilliCelsius.first != 0) && (VictronMppt.isDataValid(idx))) {
             volt = mpptData->batteryVoltage_V_mV;
             temp = mpptData->SmartBatterySenseTemperatureMilliCelsius.second;
-            _lastUpdate = VictronMppt.getDataAgeMillis(idx) + millis();
+            _lastUpdate = millis() - VictronMppt.getDataAgeMillis(idx);
             break;
         }
     }
 
-     _stats->updateFrom(volt, temp, _lastUpdate);
+    _stats->updateFrom(volt, temp, _lastUpdate);
 }