Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT powermeter fixes #1122

Merged
merged 2 commits into from
Jul 22, 2024
Merged

MQTT powermeter fixes #1122

merged 2 commits into from
Jul 22, 2024

Conversation

schlimmchen
Copy link
Member

  • initialize values/memory
  • protect all access to common memory with mutex

closes #1120.

avoid using uninitialized memory.
we previously used the mutex to protect writing the target variable.
however, we would only do that for the old usecase, where a plain float
value in Watts was expected as the topic's payload.
@schlimmchen
Copy link
Member Author

draft status as I have not yet tested the changes.

@schlimmchen schlimmchen marked this pull request as ready for review July 22, 2024 18:06
@schlimmchen schlimmchen merged commit 86a49a7 into development Jul 22, 2024
10 checks passed
@schlimmchen schlimmchen deleted the mqtt-powermeter-fixes branch July 22, 2024 18:07
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT powermeter reading wrong values (1 phase)
1 participant