Sanitize manufacturer name to avoid json errors. #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlimmchen
reviewed
Sep 6, 2024
ranma
force-pushed
the
pylontech-sanitize-manufacturer
branch
from
9393030 to
5a2ad78
Compare
schlimmchen
reviewed
Sep 7, 2024
ranma
force-pushed
the
pylontech-sanitize-manufacturer
branch
from
5a2ad78 to
837c1c6
Compare
AndreasBoehm
requested changes
Sep 8, 2024
ranma
force-pushed
the
pylontech-sanitize-manufacturer
branch
from
837c1c6 to
1b4aa4c
Compare
|
maybe it would make even more sense to add string validation to |
|
imho it makes sense to do the cleanup when we set the manufacturer string because it always makes sense to fix issues at the source of the problem and we should not pass around bad strings |
|
I agree with Andreas. The new function is not indented properly. I am going to fix this now so this can be merged. |
If the string contains control characters for some reason, the browser will reject the json with the error `bad control character in string literal`. This adds a setManufacturer function that validates the string is ASCII and will cut off the string at the first non-ascii character. Pylontech: `PYLON` (50 59 4C 4F 4E 20 20 20) Pytes: `PYTES` (50 59 54 45 53) Deye: `DY001` (44 59 30 30 31 03 E8 03) See hoylabs#1226 (comment)
schlimmchen
force-pushed
the
pylontech-sanitize-manufacturer
branch
from
1b4aa4c to
1af5a2c
Compare
|
Thanks, @ranma 🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the string contains control characters for some reason, the browser will reject the json with the error
bad control character in string literal.See #1226 (comment)