Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish ESP heap and temperature details on Mqtt #1242

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ranma
Copy link

@ranma ranma commented Sep 9, 2024

I noticed that some useful ESP stats are missing on the MQTT feed, so this adds:

  • ESP temperature
  • ESP heap stats (size, free, minFree, maxAlloc)

@ranma
Copy link
Author

ranma commented Sep 9, 2024

image

@ranma
Copy link
Author

ranma commented Sep 9, 2024

Upstream pull request: tbnobody#2268

@schlimmchen
Copy link
Member

Nice, you even recognized yourself that this is supposed to go into the upstream project as well. 💪

This is very nice, I will merge this after the next (maintenance) release, which focuses on bugfixes.

@AndreasBoehm
Copy link
Member

AndreasBoehm commented Sep 10, 2024

I think you missed the ha auto discovery part in this PR @ranma

@schlimmchen
Copy link
Member

Is there HASS autodiscovery for the uptime? If not, I don't think that it is important that we offer HASS autodiscovery for the newly added values. It would be nice, of course, but we may merge this still. We can add HASS autodiscovery later, if needed (track via issue).

@AndreasBoehm
Copy link
Member

In the upstream PR auto discovery has been added or all datapoints, its only missing in this PR.

@ranma ranma force-pushed the dtu-temp-heap-mqtt branch from 6b42991 to c5d5fe3 Compare September 11, 2024 06:43
@ranma
Copy link
Author

ranma commented Sep 11, 2024

I think you missed the ha auto discovery part in this PR @ranma

Sorry, yes. I had only realized in the upstream pullrequest that I should also add the HA auto discovery, but then hadn't upadted this one yet.

@ranma
Copy link
Author

ranma commented Sep 11, 2024

There's also the question of wether dtu/heapSize or dtu/heap/size would be preferrable as the name style :)
And then in the case of dtu/heapMinFree maybe dtu/heap/minfree or .../min_free or .../minFree?

@ranma ranma force-pushed the dtu-temp-heap-mqtt branch from c5d5fe3 to 88119d3 Compare September 11, 2024 06:50
@schlimmchen
Copy link
Member

In the upstream PR auto discovery has been added or all datapoints, its only missing in this PR.

Oh, okay, I missed that. Thanks, Andreas.

There's also the question of wether dtu/heapSize or dtu/heap/size would be preferrable as the name style :)
And then in the case of dtu/heapMinFree maybe dtu/heap/minfree or .../min_free or .../minFree?

I prefer heap/size, heap/minfree etc.

I noticed that some useful ESP stats are missing on the MQTT feed, so this adds:

- ESP temperature
- ESP heap stats (size, free, minFree, maxAlloc)
@ranma ranma force-pushed the dtu-temp-heap-mqtt branch from 88119d3 to b3ee38b Compare September 12, 2024 06:58
@schlimmchen schlimmchen merged commit 86cab0f into hoylabs:development Sep 13, 2024
8 checks passed
@ranma ranma deleted the dtu-temp-heap-mqtt branch September 14, 2024 18:12
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants