-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish ESP heap and temperature details on Mqtt #1242
Conversation
Upstream pull request: tbnobody#2268 |
Nice, you even recognized yourself that this is supposed to go into the upstream project as well. 💪 This is very nice, I will merge this after the next (maintenance) release, which focuses on bugfixes. |
I think you missed the ha auto discovery part in this PR @ranma |
Is there HASS autodiscovery for the uptime? If not, I don't think that it is important that we offer HASS autodiscovery for the newly added values. It would be nice, of course, but we may merge this still. We can add HASS autodiscovery later, if needed (track via issue). |
In the upstream PR auto discovery has been added or all datapoints, its only missing in this PR. |
6b42991
to
c5d5fe3
Compare
Sorry, yes. I had only realized in the upstream pullrequest that I should also add the HA auto discovery, but then hadn't upadted this one yet. |
There's also the question of wether |
c5d5fe3
to
88119d3
Compare
Oh, okay, I missed that. Thanks, Andreas.
I prefer |
I noticed that some useful ESP stats are missing on the MQTT feed, so this adds: - ESP temperature - ESP heap stats (size, free, minFree, maxAlloc)
88119d3
to
b3ee38b
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
I noticed that some useful ESP stats are missing on the MQTT feed, so this adds: