-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/deviceprofile dtufusion with cmt and w5500 #1259
Bugfix/deviceprofile dtufusion with cmt and w5500 #1259
Conversation
91cc2fc
to
8ff94e7
Compare
The Please explicitly unset the CMT2300 pins for the NRF+W5500 variant, as it has the same issue as you observed (when using the
Good catch, thanks! |
Should we actively disable the CMT2300 within the config |
Already thought about that - but it seems to be disabled by default |
fc009e0
to
906efeb
Compare
Of course not - thats why we need the W5500 ;) I just missed out #1253 and was annoyed by the highlighting |
Thanks 💪 |
@AndreasBoehm Yes, that's what I meant.
I did not check the code to be absolutely sure, but I think Ethernet is initialized first, occupying one SPI bus, then the NRF24 is initialized, using the second SPI bus, and then the CMT2300 is not initialized as no more SPI bus is available. To avoid a message "no more SPI bus available" and to make it absolutely clear that the CMT2300 is unusable in this case, we set the pns to -1. |
This reverts commit 27f5a94.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Fixed device profile for OpenDTU Fusion v2 to allow usage of CMT2300A with W5500. Also added missing LED mapping and explicitly disabled ETH for W5500 profiles.
Fixes #1257