Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/deviceprofile dtufusion with cmt and w5500 #1259

Conversation

vaterlangen
Copy link

@vaterlangen vaterlangen commented Sep 15, 2024

Fixed device profile for OpenDTU Fusion v2 to allow usage of CMT2300A with W5500. Also added missing LED mapping and explicitly disabled ETH for W5500 profiles.

Fixes #1257

@schlimmchen
Copy link
Member

The eth object really is redundant for the opendtufusion boards. The ESP32-S3 does not even have an Ethernet MAC. See #1253.

Please explicitly unset the CMT2300 pins for the NRF+W5500 variant, as it has the same issue as you observed (when using the opendtufusionv2 environment).

Also added missing LED mapping

Good catch, thanks!

@AndreasBoehm
Copy link
Member

Should we actively disable the CMT2300 within the config OpenDTU Fusion v2 with NRF24 and W5500 ethernet as well?

@vaterlangen
Copy link
Author

Already thought about that - but it seems to be disabled by default

@vaterlangen vaterlangen force-pushed the bugfix/deviceprofile_dtufusion_with_cmt_and_w5500 branch from fc009e0 to 906efeb Compare September 16, 2024 17:20
@vaterlangen
Copy link
Author

vaterlangen commented Sep 16, 2024

The ESP32-S3 does not even have an Ethernet MAC

Of course not - thats why we need the W5500 ;) I just missed out #1253 and was annoyed by the highlighting

@schlimmchen schlimmchen merged commit 27f5a94 into hoylabs:development Sep 16, 2024
2 checks passed
@schlimmchen
Copy link
Member

Thanks 💪

@schlimmchen
Copy link
Member

Should we actively disable the CMT2300 within the config OpenDTU Fusion v2 with NRF24 and W5500 ethernet as well?

@AndreasBoehm Yes, that's what I meant.

Already thought about that - but it seems to be disabled by default

I did not check the code to be absolutely sure, but I think Ethernet is initialized first, occupying one SPI bus, then the NRF24 is initialized, using the second SPI bus, and then the CMT2300 is not initialized as no more SPI bus is available. To avoid a message "no more SPI bus available" and to make it absolutely clear that the CMT2300 is unusable in this case, we set the pns to -1.

@vaterlangen vaterlangen deleted the bugfix/deviceprofile_dtufusion_with_cmt_and_w5500 branch September 16, 2024 22:09
schlimmchen added a commit that referenced this pull request Sep 30, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CMT2300A not working when using opendtufusionv2 with W5500 enabled
3 participants