Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion V2 RS485 SDM power meter support (RxEn, TxEn) #1269

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

Adminius
Copy link

@Adminius Adminius commented Sep 20, 2024

Tested on fusion board v2 with SDM630MCT power meter

pin_mapping.json:

        "powermeter": {
            "rx": 16,
            "tx": 45,
	    "rxen": 15,
	    "txen": 46
        }

@Adminius
Copy link
Author

Copy link
Member

@schlimmchen schlimmchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes a lot of sense. However, please keep the changes to the lib to an absolute minium.

lib/SdmEnergyMeter/SDM.cpp Outdated Show resolved Hide resolved
lib/SdmEnergyMeter/SDM.cpp Outdated Show resolved Hide resolved
lib/SdmEnergyMeter/SDM.cpp Outdated Show resolved Hide resolved
lib/SdmEnergyMeter/SDM.h Outdated Show resolved Hide resolved
src/PowerMeterSerialSdm.cpp Outdated Show resolved Hide resolved
@schlimmchen
Copy link
Member

I could test this, but I won't, at least not right now, as I trust that this works for you. The changes look clean and good and reasonable.

However, the new pins must be documented. Would you be willing to add the respective lines to the table and explain that one can either use the dere pin XOR the rxen/txen pins? Please open a pull-request against the docs repo if possible.

@schlimmchen schlimmchen merged commit 2637e32 into hoylabs:development Sep 23, 2024
9 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants