-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fusion V2 RS485 SDM power meter support (RxEn, TxEn) #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes a lot of sense. However, please keep the changes to the lib to an absolute minium.
I could test this, but I won't, at least not right now, as I trust that this works for you. The changes look clean and good and reasonable. However, the new pins must be documented. Would you be willing to add the respective lines to the table and explain that one can either use the dere pin XOR the rxen/txen pins? Please open a pull-request against the docs repo if possible. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Tested on fusion board v2 with SDM630MCT power meter
pin_mapping.json: