Add battery temperature from "Smart Battery Sense" to Victron MPPT live view

[SW-Niko]

I have integrated the battery temperature provided by the “Smart Battery Sense” into the web UI. The battery temperature is only displayed if a “Smart Battery Sense” or “BVM” is present and valid data is available.
Like on the Victron app the value will be displaced in °C without decimal places
Bugfix: Converting temperature from [K] to [°C]

Test cases:

• Display on the web UI when the "Smart Battery Sense" is present (temperature displayed)
• Display on the web UI when the "Smart Battery Sense" is not present (temperature not displayed)
• Display on the web UI when the "Smart Battery Sense" fails during operation. (temperature disappears after 10 – 60 seconds)

[schlimmchen]

Looks good, but I have two comments:

1. Please rename "Battery temperature": This label is missing a hint that this value is coming from an attached smart battery sense and the "Battery" is redundant here, as the whole card is about "Output (Battery)". How about "Smart Battery Sense Temperature"?
2. This change is missing publishing the value to MQTT and HomeAssistent auto-discovery. Please either implement both and add it to this changeset, or create an issue now to track that this is missing, so we can take care of it eventually.

[SW-Niko]

I can do that.

1. Please rename "Battery temperature":

"Smart Battery Sense Temperature" needs 2 rows on a smart phone display. How about „Temperature (SBS)“ or „SBS temperature“? I just want to avoid using more space than the currently longest text "Efficiency (calculated)"

2. This change is missing publishing the value to MQTT and HomeAssistent auto-discovery

It seems the value to MQTT and HomeAssistent auto-discovery will be published already. 🤔

See "MqttHandleVedirect.cpp" Line 141
PUBLISH_OPT(SmartBatterySenseTemperatureMilliCelsius, "SmartBatterySenseTemperature", currentData.SmartBatterySenseTemperatureMilliCelsius.second / 1000.0);

and "MqttHandleVedirectHASS.cpp" Line 98
if (optMpptData->SmartBatterySenseTemperatureMilliCelsius.first != 0) { publishSensor("Smart Battery Sense temperature", "mdi:temperature-celsius", "SmartBatterySenseTemperature", "temperature", "measurement", "°C", *optMpptData);

[schlimmchen]

It seems the value to MQTT and HomeAssistent auto-discovery will be published already. 🤔

You are absolutely right about that. I apologize for the confusion.

"Smart Battery Sense Temperature" needs 2 rows on a smart phone display.

Good point. Let's go with "SBS temperature", as you suggested. It matches "Charge controller temperature" in the "Device Info" card to the left/top.

[SW-Niko]

Ok, done. 👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.