Fix default value for discharge current limit #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlimmchen
approved these changes
Oct 8, 2024
|
@AndreasBoehm I suggest the "rebase and merge" strategy here. |
If the default type is an int, setting to a fractional value is not possible. Presumably this is because in `target.DischargeCurrentLimit = source["discharge_current_limit"] | BATTERY_DISCHARGE_CURRENT_LIMIT;` the JSON library uses the default to force the expected type and on type mismatch the default is used. As per https://arduinojson.org/v7/api/jsonvariant/or/: `defaultValue: the value to return if the JsonVariant is null or incompatible with the requested type.`
When the limit is valid, use the actual configured limit, not the bool value :)
AndreasBoehm
force-pushed
the
discharge-limit-default-float
branch
from
be23665 to
878d1fd
Compare
|
Thank you for finding and fixing those issues @ranma |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default type is an int, setting to a fractional value is not possible.
Presumably this is because in
target.DischargeCurrentLimit = source["discharge_current_limit"] | BATTERY_DISCHARGE_CURRENT_LIMIT;the JSON library uses the default to force the expected type and on type mismatch the default is used.As per https://arduinojson.org/v7/api/jsonvariant/or/:
defaultValue: the value to return if the JsonVariant is null or incompatible with the requested type.