Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vedirect Cleanups #417

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

schlimmchen
Copy link
Member

  • remove unused #defines
  • remove unused member variable
  • fix indentation and trailing whitespace

Waiting for #416 as this is based on those changes. I will rebase this after #416 is merged and then mark it ready.

@philippsandhaus
Copy link

It would be great to have this merged soon as I am also rewriting a lot in the VE.Direct classes currently #205 . The changes in this PR would also greatly simply debugging for me.

@schlimmchen schlimmchen marked this pull request as ready for review September 4, 2023 18:25
@schlimmchen
Copy link
Member Author

I rebased onto the currrent development branch. @helgeerbe this is ready to be merged into development. There is no reason to create a release, of course, as this change is purely cosmetic.

@philippsandhaus I know that I cause some headaches for you with these changes. However, it seems you appreciate the debugging capabilities that were added, so I hope you don't have to curse too much while rebasing your work. You can assume that these changes will make it into the project, so please go ahead and rebase your work on top of my branch. Later, after this PR has been merged, you rebase again onto helgeerbe/OpenDTU-OnBattery/development. Not sure if I am too verbose or not erbose enough or if you understand, what I mean. This would be my workflow, it doesn't have to be yours.

@helgeerbe helgeerbe merged commit d984912 into hoylabs:development Sep 12, 2023
8 checks passed
@schlimmchen schlimmchen deleted the vedirect-cleanups branch September 12, 2023 19:38
Copy link

github-actions bot commented Apr 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants