Huawei AC charger: prevent setting current limit when internal power control mode is enabled #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng values when internal power control mode is enabled
|
Not sure why the build failed. I did see a message about PlatformIO update though. Wonder if that could have had side effects. |
|
I opened an issue tbnobody#1500 for the failed build and fixed it with an workaround in our repo |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Huawei PSU currently allows setting current / voltage values externally when running in internal power control mode. This leads e.g. to current limits received via MQTT being applied for a brief time until they're being changed again by the power control in HuaweiCanClass. In my specific case I started to control the operation mode externally which resulted in frequent on/off switches.
This PR makes the original setValue method private (renamed to _setValue) and adds a new public setValue method that includes a check / rejects changes in this case.