Fix: switch context when handling AC charger MQTT messages #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MQTT message callbacks are executed in the MQTT thread context. when processing topics that control the huawei AC charger, we must avoid executing methods that are not thread-safe. this change bound the methods to be called to the respective parameters and executes them in the TaskScheduler context, such that they no longer need to be thread-safe.
* bind the callback to a topic (enum value) such that there is no need to tokenize the full topic (string) to find out what value is being processed. tokenizing is expensive. * get rid of using the config in the callback, which improves thread-safety since the MQTT callback is running in the MQTT thread. * prefer C++ method stof to convert MQTT value to a float, which saves us from using new and delete for a buffer in particular. * prefer switch statements over if-else-trees. * split long lines. * get rid of topic #defines. * fix indention.
schlimmchen
force-pushed
the
switch-context-on-huawei-mqtt-message
branch
from
828128a to
4632260
Compare
|
I had the urge to clean my own changes for the context switch up a little and also to clean the whole class up quite a bit. The changes were re-tested, so my statement in the description is still true: I am highly confident that this change is working well. |
|
@helgeerbe Would you consider not squashing the commits when merging, such that the first one appears as a fix in the changelog and the second one appears in the section "under the hood"? |
|
@schlimmchen sure, I do a simple merge |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT message callbacks are executed in the MQTT thread context. when processing topics that control the huawei AC charger, we must avoid executing methods that are not thread-safe. this change bound the methods to be called to the respective parameters and executes them in the TaskScheduler context, such that they no longer need to be thread-safe.
I tested this change by publishing values to the respective topics and generating a log message in the respective HuaweiClass method. Hence I am highly confident that this change does only what it is intended to do: make sure that the functions are executed in the TaskScheduler context, i.e., within the
MqttHandleHuaweiClass::loop()method.