Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: ignore v** tags #842

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

schlimmchen
Copy link
Member

this is an attempt to exempt the whole build workflow (and respective releases from being created) for upstream tags.

inspired by https://github.com/orgs/community/discussions/25615.

this is an attempt to exempt the whole build workflow (and respective releases from being created) for upstream tags.
@schlimmchen
Copy link
Member Author

@helgeerbe Are you okay with this? I would assume so, since we discussed already that we indeed do not want to publish releases for upstream tags?

@helgeerbe
Copy link
Collaborator

Not to publish. But the the tag has to be maintained. It's used to refer to the upstream version, which our release is build on.

@schlimmchen
Copy link
Member Author

Yes, we will still create the tag to name the respective commit, but there will be no re-build of the firmware for that tag and no release as part of this project.

@schlimmchen schlimmchen merged commit dae50ec into master Apr 29, 2024
10 checks passed
@schlimmchen schlimmchen deleted the workflow-ignore-upstream-tags branch April 29, 2024 19:32
@schlimmchen
Copy link
Member Author

@helgeerbe This also does not work as intended.

Look here: https://github.com/helgeerbe/OpenDTU-OnBattery/actions/runs/8944133856 See the "workflow file" under "run details" on the left. This is not our workflow file, it's the upstream workflow file. So, since we keep pushing upstream tags, which point to upstream commits and upstream versions of the repo, the build run will be triggered with the respective upstream workflow file, which does not have our filter (obviously).

I guess we should resort to deleting such releases. Or we could abort the github actions after pushing upstream commits, which would be better, as no release is created and no emails alerting about the new release are generated.

Copy link

github-actions bot commented Jun 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants