Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for Huawei BatterySoC Limit < 100 #992

Merged
merged 3 commits into from
May 30, 2024

Conversation

eu-gh
Copy link

@eu-gh eu-gh commented May 20, 2024

Someone™ introduced the feature to set a maximum SoC limit for the combination Pylontech battery <-> Huawei AC charger. I've seen cases of a reported SoC of 100, but the BMS still requesting further charging, probably in order to do a proper cell calibration/soaking phase.

I added the simple exclude for an SoC Threshold < 100. Instead, the cutoff will be triggered by the BMS itself using the awesome new getChargeCurrentLimitation() method.

@schlimmchen
Copy link
Member

@MalteSchm I guess this can be merged. However, I would be more confident if you'd agree.

@MalteSchm
Copy link

MalteSchm commented May 23, 2024

So your change essentially says:
If the user configured a SoC target of 100 there is no point in stopping and we disable this functionality.

Maybe I'm tired but it took me a longer time to figure this out. Could I ask you to clarify this in a comment?

@eu-gh
Copy link
Author

eu-gh commented May 24, 2024

// Done.

However, your comment made me realize that switching off the SoC limit toggle in the settings already does exactly the same thing. So I guess it would make more sense to simply don't accept values above 99 inside the UI, which is cleaner and also eliminates the problem I was trying to solve here.

FYI, I also added a clarification to the comment in line 432, since for people only using the Huawei charger (like me), it looks kind of redundant to add and subtract a current delta of almost zero over and over again.

@schlimmchen schlimmchen merged commit 90eb25f into hoylabs:development May 30, 2024
8 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants