Skip to content

Commit

Permalink
Ensure that the D-Bus directory for tests has suitable permissions
Browse files Browse the repository at this point in the history
The D-Bus directory must not be writable by other users:

  dbus: Unable to set up transient service directory: XDG_RUNTIME_DIR "." can be written by others (mode 040775)

Fixes test failure when building with less restrictive umask 0002.

Detected-by: Reproducible Builds <https://reproducible-builds.org/>
See-also: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mpv-mpris.html
  • Loading branch information
pabs3 authored and hoyon committed Apr 6, 2022
1 parent fecc6ca commit 1b02341
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion test/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ clean:
*.socat.log \
*.exit-code.log \
*.stderr.log
rm -rf dbus-1
rm -rf dbus
4 changes: 4 additions & 0 deletions test/env
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ writable_dir "$MPV_MPRIS_TEST_LOG"
writable_dir "$MPV_MPRIS_TEST_TMP"


MPV_MPRIS_TEST_DBUS="$MPV_MPRIS_TEST_DBUS/dbus"
mkdir -p -m 0700 "$MPV_MPRIS_TEST_DBUS"


# These are not used outside this script so unexport them
export -n \
MPV_MPRIS_TEST_DBUS \
Expand Down

0 comments on commit 1b02341

Please sign in to comment.