Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List variables can now extend config items #753

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

Paul-Ferrell
Copy link
Collaborator

  • List variables can now be used to extend config items.
  • Variable lists cannot be extended in this way.

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

- List variables can now be used to extend config items.
- Variable lists cannot be extended in this way.
tygoetsch
tygoetsch previously approved these changes Mar 4, 2024
whitespace fix
Copy link
Collaborator

@tygoetsch tygoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the meeting this morning, I think additional documentation of the functions and their behavior would be welcome. Up to you to decide if the current documentation is appropriate though.

@Paul-Ferrell Paul-Ferrell merged commit 7a77c9b into master Mar 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants