Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

719 ability to cancel series run by other users #779

Merged
merged 29 commits into from
Nov 13, 2024
Merged

719 ability to cancel series run by other users #779

merged 29 commits into from
Nov 13, 2024

Conversation

hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl linked an issue Jul 31, 2024 that may be closed by this pull request
Ability to cancel series run by other users #719
Closed
@hwikle-lanl hwikle-lanl requested a review from Paul-Ferrell July 31, 2024 20:04
@hwikle-lanl hwikle-lanl marked this pull request as ready for review August 7, 2024 15:55
@hwikle-lanl hwikle-lanl force-pushed the 719-ability-to-cancel-series-run-by-other-users branch from 505f866 to 1c6e38f Compare September 9, 2024 19:22
@hwikle-lanl hwikle-lanl marked this pull request as draft September 11, 2024 22:22
@hwikle-lanl hwikle-lanl force-pushed the 719-ability-to-cancel-series-run-by-other-users branch from 1c6e38f to 1451f98 Compare September 30, 2024 19:26
Paul-Ferrell
Paul-Ferrell previously approved these changes Oct 7, 2024
View reviewed changes
@hwikle-lanl hwikle-lanl force-pushed the 719-ability-to-cancel-series-run-by-other-users branch from b6e7360 to 2088cda Compare November 4, 2024 15:15
@hwikle-lanl hwikle-lanl marked this pull request as ready for review November 8, 2024 18:04
@hwikle-lanl hwikle-lanl merged commit 0d1009f into develop Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelapid francinelapid francinelapid approved these changes

@Paul-Ferrell Paul-Ferrell Paul-Ferrell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to cancel series run by other users
3 participants
@hwikle-lanl @Paul-Ferrell @francinelapid