Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

789 pav status raises exception when invoked before running tests #790

Conversation

hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl self-assigned this Nov 14, 2024
@hwikle-lanl hwikle-lanl linked an issue Nov 14, 2024 that may be closed by this pull request
@hwikle-lanl
Copy link
Collaborator Author

Removed the raised exception and returned None instead, since the caller is checking for None anyways, and because it makes more sense generally.

@hwikle-lanl
Copy link
Collaborator Author

I'm also not 100% sure this unit test actually tests what it's meant to, but it passes.

Copy link
Collaborator

@francinelapid francinelapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on pav_tutorial. It now gives the message: User has no 'last' series for this machine.

Thanks for adding a unit test too!

@hwikle-lanl hwikle-lanl merged commit 3c262de into develop Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pav status Raises Exception When Invoked Before Running Tests
2 participants